-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9528/
-----------------------------------------------------------
(Updated Feb. 26, 2013, 2:14 a.m.)
Review request for shindig.
Changes
-------
Adding JUnit implementations for the changes.
Also made on API on HttpResponse public. The rest of the non-mutating getters
are public, so I don't see any harm in it.
Description
-------
>From JIRA:
Currently the DefaultRequestPipeline will attempt to complete requests for data
that is already in the httpResponses cache but which is stale. There is an
opportunity here to set If-Modified-Since and If-None-Match headers on the
outbound request (i.e. to trigger a conditional get) and to handle a 304 Not
Modified response.
This addresses bug SHINDIG-1905.
https://issues.apache.org/jira/browse/SHINDIG-1905
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java
1449986
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java
1449986
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java
1449986
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java
1449986
Diff: https://reviews.apache.org/r/9528/diff/
Testing
-------
None as of yet. JUnits have been stubbed out with TODO items. Once the
concept of the changes are agreed upon I will take the time to implement the
JUnits.
Thanks,
Stanton Sievers
