-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9528/
-----------------------------------------------------------

(Updated March 7, 2013, 9:40 p.m.)


Review request for shindig.


Changes
-------

Adding javadoc per Ryan's comment.


Description
-------

>From JIRA: 
Currently the DefaultRequestPipeline will attempt to complete requests for data 
that is already in the httpResponses cache but which is stale. There is an 
opportunity here to set If-Modified-Since and If-None-Match headers on the 
outbound request (i.e. to trigger a conditional get) and to handle a 304 Not 
Modified response. 


This addresses bug SHINDIG-1905.
    https://issues.apache.org/jira/browse/SHINDIG-1905


Diffs (updated)
-----

  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java
 1449986 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java
 1449986 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java
 1449986 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java
 1449986 

Diff: https://reviews.apache.org/r/9528/diff/


Testing
-------

JUnits have been added for the changes.


Thanks,

Stanton Sievers

Reply via email to