----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14710/#review27121 -----------------------------------------------------------
Ship it! LGTM, just fix up the whitespace (red markers in diff). - Ryan Baxter On Oct. 17, 2013, 11:37 a.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14710/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 11:37 a.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1941 > https://issues.apache.org/jira/browse/SHINDIG-1941 > > > Repository: shindig > > > Description > ------- > > See the linked bug: NPE happens when an empty JSON object is to be > deserialized into a class implementing ExtendableBean. > > Please note: the patch was created against the 3.0.0-beta3 tag, but the issue > does affect 2.5.0-updateX as well. > > > Diffs > ----- > > > trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanJsonConverter.java > 1532688 > > trunk/java/common/src/test/java/org/apache/shindig/protocol/conversion/BeanJsonConverterTest.java > 1532688 > > Diff: https://reviews.apache.org/r/14710/diff/ > > > Testing > ------- > > Unit test in the patch. > > Issue reproduced before that in our production environment, and no longer > reproducible after the patch was applied. > > > Thanks, > > Andreas Kohn > >
