-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14710/
-----------------------------------------------------------

(Updated Nov. 11, 2013, 9:28 a.m.)


Review request for shindig.


Changes
-------

Regenerate the patch against r1540645.

I think the main issue here is that reviewboard/svn and me/mercurial disagree 
on the number of slashes to strip (svn uses -p0, mercurial uses -p1). 


Bugs: SHINDIG-1941
    https://issues.apache.org/jira/browse/SHINDIG-1941


Repository: shindig


Description
-------

See the linked bug: NPE happens when an empty JSON object is to be deserialized 
into a class implementing ExtendableBean.

Please note: the patch was created against the 3.0.0-beta3 tag, but the issue 
does affect 2.5.0-updateX as well.


Diffs (updated)
-----

  
trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanJsonConverter.java
 1540645 
  
trunk/java/common/src/test/java/org/apache/shindig/protocol/conversion/BeanJsonConverterTest.java
 1540645 

Diff: https://reviews.apache.org/r/14710/diff/


Testing
-------

Unit test in the patch.

Issue reproduced before that in our production environment, and no longer 
reproducible after the patch was applied.


Thanks,

Andreas Kohn

Reply via email to