----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15413/#review28648 -----------------------------------------------------------
I haven't had a chance to apply this patch and try it out, so this may be an invalid concern. My concern is that it is working in the unit tests because you've explicitly bound the properties in SocialApiTestsGuiceModule but that they won't be bound in the runtime environment per the TODO item. trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImpl.java <https://reviews.apache.org/r/15413/#comment55557> Were you able to overcome the issue outlined in this TODO? - Stanton Sievers On Nov. 11, 2013, 11:06 a.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15413/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2013, 11:06 a.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1949 > https://issues.apache.org/jira/browse/SHINDIG-1949 > > > Repository: shindig > > > Description > ------- > > Inject shindig.oauth2.authCodeExpiration, > shindig.oauth2.accessTokenExpiration and > shindig.oauth2.refreshTokenExpiration. > > Note that shindig.oauth2.refreshTokenExpiration is already bound in the test > module, but not yet used in the Oauth2ServiceImpl. > > > Diffs > ----- > > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImpl.java > 1540645 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java > 1540645 > > Diff: https://reviews.apache.org/r/15413/diff/ > > > Testing > ------- > > Unit tests still pass. > > > Thanks, > > Andreas Kohn > >
