----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15413/#review28729 -----------------------------------------------------------
Ship it! Ship It! - Stanton Sievers On Nov. 11, 2013, 2:34 p.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15413/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2013, 2:34 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1949 > https://issues.apache.org/jira/browse/SHINDIG-1949 > > > Repository: shindig > > > Description > ------- > > Inject shindig.oauth2.authCodeExpiration, > shindig.oauth2.accessTokenExpiration and > shindig.oauth2.refreshTokenExpiration. > > Note that shindig.oauth2.refreshTokenExpiration is already bound in the test > module, but not yet used in the Oauth2ServiceImpl. > > > Diffs > ----- > > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImpl.java > 1540645 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java > 1540645 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImplTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15413/diff/ > > > Testing > ------- > > Unit tests still pass. > > > Thanks, > > Andreas Kohn > >
