nudles commented on issue #599: Enabled linting check in CI URL: https://github.com/apache/singa/pull/599#issuecomment-590334641 > > > I am not sure if linting should be in the build.sh file. This file is executed to test the build of the code, while linting is not related to the build test. It is part of "static code analysis". I would propose to have a new test machine in ".travis.yml" for the static code checks such as linting. > > Something like: > > * os: linux > dist: bionic > compiler: gcc > name: "Ubuntu 18.04 (Static Analysis)" > script: > - bash -ex tool/linting/linting.sh > > > and this machine will run only the script of linting (without building). > > Otherwise, this pull request will run the linting four times with each build which is not necessary. > > what do you think? + 1. Agree.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
