moazreyad commented on issue #599: Enabled linting check in CI URL: https://github.com/apache/singa/pull/599#issuecomment-591966612 but why you used two machines for the static analysis? May be one is enough with two scripts for cpp and python: ``` - os: linux stage: linting dist: bionic compiler: gcc name: "Ubuntu 18.04 (Static Analysis)" script: - bash -ex tool/linting/cpp.sh - bash -ex tool/linting/py.sh ``` The static analysis machine can be used also for RAT test, similar to [Apache HAWQ](https://github.com/apache/hawq/blob/master/.travis.yml#L83) and [Apache servicecomb](https://github.com/apache/servicecomb-java-chassis/blob/master/scripts/travis.sh#L34), may be something like: ``` script: - bash -ex tool/linting/cpp.sh - bash -ex tool/linting/py.sh - bash -ex tool/rat/rat.sh ``` and in the rat.sh, something like: ``` mvn apache-rat:check if [ $? != 0 ]; then echo "${red}Rat check failed.${reset}" exit 1 fi ``` This automatic check of licence headers with RAT will make the release process faster. Because now we have to do it manually before the release.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
