nudles commented on a change in pull request #416: singa-onnx
URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264291619
##########
File path: python/singa/sonnx.py
##########
@@ -258,8 +258,8 @@ def to_onnx_model(inputs, y, model_name='sonnx'):
dependency = autograd.infer_dependency(y.creator)
ready = deque([y.creator])
- def output_name(op):
- return '{}'.format(op.name)
+ def output_name(op,extra=''):
+ return '{}'.format(op.name+str(extra))
Review comment:
extra is a str? then why do you the type conversion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
