nudles commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264954977
########## File path: python/singa/tensor.py ########## @@ -107,9 +107,14 @@ def __init__(self, shape=(), device=None, dtype=float32, self.dtype = self.data.data_type() self.requires_grad = requires_grad self.stores_grad = stores_grad + if name is None: + self.name = 'Dummy#{}'.format(Tensor.tensor_count) Review comment: we only need to give a name to the input tensors. for the tensors generated by operations, the name should be set by the output_name() function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services