ShichengChen commented on a change in pull request #416: singa-onnx URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264956297
########## File path: python/singa/autograd.py ########## @@ -614,10 +682,28 @@ def __call__(self, x): y = add_bias(y, self.b, axis=0) return y + def get_params(self): + if self.bias: + return {'W': self.W, 'b': self.b} + else: + return {'W': self.W} + + def set_params(self, **parameters): Review comment: no, I will not use this function ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services