ShichengChen commented on a change in pull request #416: singa-onnx
URL: https://github.com/apache/incubator-singa/pull/416#discussion_r264957034
##########
File path: python/singa/tensor.py
##########
@@ -107,9 +107,14 @@ def __init__(self, shape=(), device=None, dtype=float32,
self.dtype = self.data.data_type()
self.requires_grad = requires_grad
self.stores_grad = stores_grad
+ if name is None:
+ self.name = 'Dummy#{}'.format(Tensor.tensor_count)
Review comment:
`node.append(helper.make_node('Concat',
inputs=inputs,
outputs=outputs,
name=op.name,
axis=op.axis))`
for the tensors generated by operations
output parameter is set by output_name()
name parameter is set by op.name
should i change name parameter to output_name() too? same as output
parameter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
