dcslin commented on a change in pull request #445: SINGA-433 updated
documentation about docker, dockerfile for consitent, cudnn version in
dockerfile
URL: https://github.com/apache/incubator-singa/pull/445#discussion_r272034982
##########
File path: cmake/Dependencies.cmake
##########
@@ -144,9 +144,8 @@ ENDIF()
IF(USE_MKLDNN)
FIND_PATH(MKLDNN_INCLUDE_DIR NAME "mkldnn.hpp" PATHS
"$ENV{CMAKE_INCLUDE_PATH}")
- FIND_LIBRARY(MKLDNN_LIBRARIES NAME "libmkldnn.so" PATHS
"$ENV{CMAKE_LIBRARY_PATH}")
- FIND_LIBRARY(MKLML_LIBRARIES NAME "libmklml_intel.so" PATHS
"$ENV{CMAKE_LIBRARY_PATH}")
Review comment:
Yes. the test works without MLKML. I have removed MKLML in cmake and
dockerfile. All 5 dockerfiles are tested (runtime only tested import and init
objects) and testing are passing.
The last thing left is testing on OSX for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
