nudles commented on a change in pull request #492: Make singa use multiple
memory pools
URL: https://github.com/apache/incubator-singa/pull/492#discussion_r308745750
##########
File path: include/singa/core/device.h
##########
@@ -295,7 +295,9 @@ class Platform {
/// Create a set of CudaGPU Device using given GPU IDs.
static const std::vector<std::shared_ptr<Device>>
CreateCudaGPUsOn(const std::vector<int> &devices, size_t init_size = 0);
-
+
+ static std::vector<std::shared_ptr<Device> > allRet;
Review comment:
should they be static members of Platform?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
