nudles commented on a change in pull request #492: Make singa use multiple
memory pools
URL: https://github.com/apache/incubator-singa/pull/492#discussion_r309955069
##########
File path: src/core/device/platform.cc
##########
@@ -133,8 +154,11 @@ Platform::CreateCudaGPUsOn(const vector<int> &devices,
size_t init_size) {
vector<shared_ptr<Device> > ret;
for (auto device : devices) {
auto dev = std::make_shared<CudaGPU>(device, pool);
- ret.push_back(dev);
+ UsedDevice[device]=dev;
}
+ int count = Platform::GetNumGPUs();
+ for(int i = 0;i < count;i++)if(UsedDevice[i]!=nullptr)
Review comment:
no comments and the code is not formatted following google style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
