[
https://issues.apache.org/jira/browse/SLIDER-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037283#comment-15037283
]
Pan Yuxuan commented on SLIDER-1005:
------------------------------------
[~ste...@apache.org]
I have attached a patch for this, move the plugin from profile to build.
And I also remove the generated java classes
slider-core/src/main/java/org/apache/slider/api/proto/Messages.java and
slider-core/src/main/java/org/apache/slider/api/proto/SliderClusterAPI.java.
Please take a look to see how you think of it.
Patch: SLIDER-1005-001.patch
> The java code generated by protobuf should not be placed in src directory
> -------------------------------------------------------------------------
>
> Key: SLIDER-1005
> URL: https://issues.apache.org/jira/browse/SLIDER-1005
> Project: Slider
> Issue Type: Improvement
> Components: build, core
> Affects Versions: Slider 0.90
> Environment: Centos 6.5, Maven 3.2.5
> Reporter: Pan Yuxuan
> Assignee: Pan Yuxuan
> Priority: Minor
> Attachments: SLIDER-1005-001.patch
>
>
> Now slider using protobuf for RPC, but the output directory is
> <output>${basedir}/src/main/java</output> in slider-core/pom.xml. That means
> the generated java code was been placed in the src directory.
> I have seen the generated java code for protobuf in Hadoop, they put the code
> in build directory
> <output>${project.build.directory}/generated-sources/java</output>. And they
> put the compile-protoc in <plugin> not <profile> in the pom.xml.
> I think the way Hadoop used is more reasonable. The code is generated by
> protobuf, not by ourselves.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
