[
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134761#comment-15134761
]
shanyu zhao commented on SLIDER-1079:
-------------------------------------
Thanks [~jmaron] for your feedback. I addressed 1) and 2) in the new patch. For
3) I think the existing unit tests testGetApplicationTags() and
testValidateInstanceDefinition() already exercise getMetainfo() method, so it
wouldn't add much value if I add additional. Let me know what you think.
> Cache MetaInfo for AgentClientProvider
> --------------------------------------
>
> Key: SLIDER-1079
> URL: https://issues.apache.org/jira/browse/SLIDER-1079
> Project: Slider
> Issue Type: Bug
> Components: client
> Affects Versions: Slider 0.81, Slider 0.90.2
> Reporter: shanyu zhao
> Assignee: shanyu zhao
> Attachments: SLIDER-1079.1.patch, SLIDER-1079.patch
>
>
> During app creation, the slider client calls
> AgentUtils.getApplicationMetainfo() 3 times. Each time this function actually
> download the whole app package from HDFS. If the app package is big, this is
> rather inefficient.
> The 3 places are:
> 1) SliderClient.actionBuild() ->
> AgentClientProvider.validateInstanceDefinition()
> 2) AgentClientProvider.getApplicagionTags()
> 3) AgentClientProvider.validateInstanceDefinition()
> We should cache the metainfo object in AgentClientProvider.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
