[ 
https://issues.apache.org/jira/browse/SLIDER-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330884#comment-15330884
 ] 

Gour Saha commented on SLIDER-1079:
-----------------------------------

It is actually a valid usage. App owners in the early phase of app development 
typically do not have multiple versions of their app. They create, destroy and 
re-create (multiple times) the same version of the app with the same name as 
well. That's when the issue occurs. Nevertheless, I think we will still be able 
to reap the benefit of this cache without making it static. 

If you are okay with it I am going to keep the feature around, but just convert 
the cache to be at the request level.

> Cache MetaInfo for AgentClientProvider
> --------------------------------------
>
>                 Key: SLIDER-1079
>                 URL: https://issues.apache.org/jira/browse/SLIDER-1079
>             Project: Slider
>          Issue Type: Bug
>          Components: client
>    Affects Versions: Slider 0.81, Slider 0.90.2
>            Reporter: shanyu zhao
>            Assignee: shanyu zhao
>             Fix For: Slider 0.91
>
>         Attachments: SLIDER-1079.1.patch, SLIDER-1079.patch
>
>
> During app creation, the slider client calls 
> AgentUtils.getApplicationMetainfo() 3 times. Each time this function actually 
> download the whole app package from HDFS. If the app package is big, this is 
> rather inefficient.
> The 3 places are:
> 1) SliderClient.actionBuild() -> 
> AgentClientProvider.validateInstanceDefinition()
> 2) AgentClientProvider.getApplicagionTags()
> 3) AgentClientProvider.validateInstanceDefinition()
> We should cache the metainfo object in AgentClientProvider.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to