Justin Edelson wrote
> On Wed, Aug 18, 2010 at 1:38 PM, Justin Edelson <justinedel...@gmail.com>
> wrote:
>> I fixed the ConfigInstallTest failure in the osgi.it module. Not sure if
>> this is the one which has been "failing for a long time".
Great! Thanks Justin.
>>
>> The problem is in the waitForConfiguration method of OsgiInstallerTestBase.
>>
>> The logic was:
>> if (result != null ||!shouldBePresent) {
>> break;
>> }
>>
>> but this fails to take into account when we want result to be null. As
>> such, the sleep was never happening.
>>
>> After this fix, I did get another test failure due to an
>> IllegalStateException. It seems that this happens if a Configuration is
>> deleted between the time ConfigurationAdmin.listConfigurations(null) and
>> cfg.getPid() are called (in the findConfiguration method). I think the
>> only way to avoid this is to increase the sleep time between
>> configuration checks from 25 ms to 250 ms.
> I went another way and am catching the IllegalStateException.
>
>>
>> Carsten - what's the other IT you see fail consistently?
Still, the ConfigInstallTest.testDeferredConfigInstall is failing for
me: Expected ConfigurationAdmin to be absent expected:<false> but was:<true>
Everything else passes now.
> Is it RemovedResourceDetectionTest? I saw that fail twice now, but
> haven't been able to reproduce it either while debugging or with
> pax.exam.log.level=DEBUG.
Yes, this failed for me once but then never again. Maybe this is a
timing problem.
Regards
Carsten
--
Carsten Ziegeler
cziege...@apache.org
