[ https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229157#comment-17229157 ]
Bertrand Delacretaz edited comment on SLING-2938 at 11/10/20, 11:58 AM: ------------------------------------------------------------------------ [~kwin] wrote: {quote}(the existing) [https://github.com/apache/sling-adapter-annotations] is used by [https://sling.apache.org/components/sling-maven-plugin/generate-adapter-metadata-mojo.html] to build JSON metadata (only evaluated in the Felix WebConsole). It won't generate the actual SCR definitions. Compare also with [https://sling.apache.org/documentation/the-sling-engine/adapters.html#implementing-adaptable]. {quote} Turns out that [that old module|https://github.com/apache/sling-adapter-annotations] was already released as "Adapter Annotations 1.0.0" so we need at least to bump the version to 2.0.0 for the [new module|https://github.com/apache/sling-org-apache-sling-adapter-annotations], or change its name to avoid confusion. I'll [discuss on our dev list|https://lists.apache.org/thread.html/rc9ddd78b8cebf501e24c064afaa4c3cd152589f22480837aeb1c741a%40%3Cdev.sling.apache.org%3E]. I had already created the staging repo at [https://repository.apache.org/content/repositories/orgapachesling-2371] when I noticed that potential confusion, will delete it once we agree on how to release the new module. was (Author: bdelacretaz): [~kwin] wrote: bq. (the existing) https://github.com/apache/sling-adapter-annotations is used by https://sling.apache.org/components/sling-maven-plugin/generate-adapter-metadata-mojo.html to build JSON metadata (only evaluated in the Felix WebConsole). It won't generate the actual SCR definitions. Compare also with https://sling.apache.org/documentation/the-sling-engine/adapters.html#implementing-adaptable. Turns out that [that old module|https://github.com/apache/sling-adapter-annotations] was already released as "Adapter Annotations 1.0.0" so we need at least to bump the version to 2.0.0 for the [new module|https://github.com/apache/sling-org-apache-sling-adapter-annotations], or change its name to avoid confusion. I'll discuss on our dev list. I had already created the staging repo at https://repository.apache.org/content/repositories/orgapachesling-2371 when I noticed that potential confusion, will delete it once we agree on how to release the new module. > AdapterMethods annotation and adapter proxy service > --------------------------------------------------- > > Key: SLING-2938 > URL: https://issues.apache.org/jira/browse/SLING-2938 > Project: Sling > Issue Type: Bug > Components: Engine, Extensions > Affects Versions: Adapter 2.1.0 > Reporter: Bertrand Delacretaz > Assignee: Bertrand Delacretaz > Priority: Minor > Attachments: SLING-2938-api.patch, console.jpg > > > Following up on an idea that Olaf Otto presented at CQCon last week, I've > been working on an @AdapterMethod annotation that makes it easier to create > Sling adapters, as in > @Component > @Service > public class MyAdapters implements AdapterMethodProvider { > @AdapterMethod > public Bar toBar(Foo f) { ... adapt Foo to Bar ... } > } > As this requires changes to the sling.api bundle, I'll commit to my > whiteboard first, for review -- This message was sent by Atlassian Jira (v8.3.4#803005)