[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227985#comment-17227985
]
Henry Kuijpers edited comment on SLING-2938 at 11/8/20, 1:04 PM:
-----------------------------------------------------------------
[~bdelacretaz], I had a quick look over the changes you did and they look very
good to me. :) I'm also happy with the fact that the IT and the annotations are
now in the same project, this makes much more sense.
With regards to the build that you were referencing, indeed, somehow this
project was "right in time" added to Sonar, it seems? :)
As I said in the PR: +1 from me to merge in the changes and put out a release
very soon. :)
(Unfortunately I do not have write access to the repository, so I can't do the
merge.)
was (Author: henry kuijpers):
[~bdelacretaz], I had a quick look over the changes you did and they look very
good to me. :) I'm also happy with the fact that the IT and the annotations are
now in the same project, this makes much more sense.
With regards to the build that you were referencing, indeed, somehow this
project was "right in time" added to Sonar, it seems? :)
As I said in the PR: +1 from me to merge in the changes and put out a release
very soon. :)
> AdapterMethods annotation and adapter proxy service
> ---------------------------------------------------
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
> Issue Type: Bug
> Components: Engine, Extensions
> Affects Versions: Adapter 2.1.0
> Reporter: Bertrand Delacretaz
> Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've
> been working on an @AdapterMethod annotation that makes it easier to create
> Sling adapters, as in
> @Component
> @Service
> public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
> }
> As this requires changes to the sling.api bundle, I'll commit to my
> whiteboard first, for review
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
