cmrockwell commented on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-733019791
Thanks! @bdelacretaz I'll try using the example you gave.
@jsedding I have another other question for you. I'm getting many many
errors in the console like the one below
> ERROR: Bundle org.apache.sling.junit.core [189] EventDispatcher: Error
during dispatch. (java.lang.NoClassDefFoundError:
org/junit/platform/engine/TestEngine)
java.lang.NoClassDefFoundError: org/junit/platform/engine/TestEngine
at
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.getTestEnginesForBundle(TestEngineTracker.java:83)
at
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.addingBundle(TestEngineTracker.java:67)
at
org.apache.sling.junit.impl.servlet.junit5.TestEngineTracker$Customizer.addingBundle(TestEngineTracker.java:63)
at
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:475)
at
org.osgi.util.tracker.BundleTracker$Tracked.customizerAdding(BundleTracker.java:420)
at
org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
at
org.osgi.util.tracker.BundleTracker$Tracked.bundleChanged(BundleTracker.java:450)
at
org.apache.felix.framework.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:915)
at
org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:834)
at
org.apache.felix.framework.EventDispatcher.fireBundleEvent(EventDispatcher.java:516)
at org.apache.felix.framework.Felix.fireBundleEvent(Felix.java:4817)
at org.apache.felix.framework.Felix.start(Felix.java:1116)
at
org.apache.sling.feature.launcher.impl.launchers.AbstractRunner$4.call(AbstractRunner.java:232)
at
org.apache.sling.feature.launcher.impl.launchers.AbstractRunner$4.call(AbstractRunner.java:228)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
[INFO] Framework started
Seems this version of org.apache.sling.junit.core had this optional
Import-Package added from
[SLING-9795](https://github.com/apache/sling-org-apache-sling-junit-core/commit/8a30309ddebaa86a9edf399d410fe891c15dbf7d#diff-6d1033f3cc4642b36cd395cf203fdc2d963f51e46cb1949508765a9756743c45)
`Import-Package: org.junit.platform.*;resolution:=optional, \`
Is this something to be addressed here or later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
