bdelacretaz commented on pull request #5:
URL: 
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#issuecomment-733602302


   > Even with Java 8, my version fails. The system properties are null...
   
   The main issue was that the test was mistakenly run by 
`maven-surefire-plugin` due to the class name starting with `Test...`, so the 
failsafe plugin was not applied. Took some head-scratching to figure out ;-)
   
   I have made a few other changes: added the `settings.xml` file to avoid 
Downloading The Web when running the tests from the invoker plugin, and I had 
to switch to our parent pom 33 as the IT bundle was not built correctly with 
40, haven't investigated, and a few minor changes. With commit 99d8a32ba the 
ITs work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to