kwin commented on a change in pull request #61:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/61#discussion_r593101084



##########
File path: 
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java
##########
@@ -101,6 +101,9 @@
     @Option(names = { "--enforce-principal-based-supported-path" }, 
description = "Converts service user access control entries to principal-based 
setup using the given supported path.", required = false)
     private String enforcePrincipalBasedSupportedPath = null;
 
+    @Option(names = { "--enforce-servicemapping-by-principal" }, description = 
"Converts service user mappings with the form 'service:sub=userID' to 
'service:sub=[principalname]'.", required = false)

Review comment:
       It should be clarified how the mapping is done: To which degree are the 
user's group membership considered?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to