kwin commented on a change in pull request #61:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/61#discussion_r594952299
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/Mapping.java
##########
@@ -60,6 +66,9 @@ public Mapping(@NotNull final String spec) {
if (s.charAt(0) == '[' && s.charAt(s.length()-1) == ']') {
this.userName = null;
this.principalNames = extractPrincipalNames(s);
+ } else if (enforceMappingByPrincipal) {
+ this.userName = null;
+ this.principalNames = Collections.singleton(s);
Review comment:
My comment was referring to the fact that you change user id to
principal names which changes the semantics as long as you don't consider the
transitive group memberships (see my other comment).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
