On Thursday, 8 April 2021 15:48:27 CEST Radu Cotescu wrote: > Hi Olli, Hi Radu,
> > On 1 Apr 2021, at 21:26, Oliver Lietz <apa...@oliverlietz.de> wrote: > > > > I have a use case for ResourceType not related to Scripting and would like > > to see it in Sling API (see SLING-9999 for reasons) where it fits well. > > > > https://github.com/apache/sling-org-apache-sling-scripting-spi/blob/master > > / > > <https://github.com/apache/sling-org-apache-sling-scripting-spi/blob/mast > > er/> src/main/java/org/apache/sling/scripting/spi/bundle/ResourceType.java > > > > WDYT? > > I’ve already replied to your concern at [0], but I don’t mind repeating what > I said: > > “If we really need to use the ResourceType class somewhere else, we can move > it to the o.a.s.api bundle when the time comes. We can then deprecate the > one from o.a.s.scripting.spi and remove it once there will be other > incompatible changes added by the other interfaces. Until then, I really > don't see the need to spread 5 interfaces over 2 bundles and increase the > dependency footprint for the current consumers.” And still it does not make sense nor is it consistent. My initial proposal was to have the Bundle API in bundle o.a.s.scripting.api (no additional bundle) but you rejected to not depend on Scripting API. The o.a.s.scripting.spi bundle is fine but the class (not an interface) ResourceType should be in Sling API from the beginning: - it is useful in different contexts not related to Scripting - better visibility in Sling API - most modules depend on Sling API anyways - close to Resource classes (o.a.s.api.resource), similar helpers (e.g. o.a.s.api.resource.path) - BundledRenderUnitCapability depends on ResourceType, moving/changing it later is a major change (we try to prevent such breaking changes in Sling) - it is no effort to do it now, we need a new release of Sling API anyways > Unless you have something already committed to a repository from which you > plan to cut a release soon I'd prefer to go ahead without it for now. So for now would mean never, see above. Regards, O. > Cheers, > Radu > > [0] - > https://issues.apache.org/jira/browse/SLING-9999?focusedCommentId=17295320&; > page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#commen > t-17295320
