[ 
https://issues.apache.org/jira/browse/SLING-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325607#comment-17325607
 ] 

Stefan Bischof edited comment on SLING-10213 at 4/20/21, 10:01 AM:
-------------------------------------------------------------------

[~karlpauls]

If I understand in right this means to add the `ClasspathArtifacts`(searching 
for a better name) to 
[ExecutionEnvironmentExtension.java|https://github.com/apache/sling-org-apache-sling-feature/blob/master/src/main/java/org/apache/sling/feature/ExecutionEnvironmentExtension.java]

Like this?
 
[https://github.com/stbischof/sling-org-apache-sling-feature/commit/81b47f2084aca2322cb76262009239fd9a8c33a3
]

and use it in the Processor like

https://github.com/apache/sling-org-apache-sling-feature-launcher/commit/dfbe2f39ffecf1b39e604241b129db75c04a8349


was (Author: bisch...@jena.de):
[~karlpauls] 

If i understand in right this means to add the `ClasspathArtefacts` to 
[ExecutionEnvironmentExtension.java|https://github.com/apache/sling-org-apache-sling-feature/blob/master/src/main/java/org/apache/sling/feature/ExecutionEnvironmentExtension.java]

Like this?
https://github.com/stbischof/sling-org-apache-sling-feature/commit/81b47f2084aca2322cb76262009239fd9a8c33a3

> Feature-Launcher: Add Extensions to Classpath 
> ----------------------------------------------
>
>                 Key: SLING-10213
>                 URL: https://issues.apache.org/jira/browse/SLING-10213
>             Project: Sling
>          Issue Type: New Feature
>          Components: Feature Model
>            Reporter: Stefan Bischof
>            Priority: Major
>
> In this 
> [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18]
>  about the docker container SlingFeatureLauncher of
> @karlpauls came up with this:
> in general, it be good if there was a way to add extension jars to the class 
> path. We need them for both, merge handlers as well as launcher extensions. 
> I'm not sure what the best way would be - maybe somehow (deep search) find 
> all jars in a well known location so that one could selectively mount in 
> extensions?
> From my point of view it would be nice to have the mecanism that works same 
> in docker and default java launcher.
> What do you think about an ExtentionInstaller-Extension? So we can hold 
> everything in the Feature-file and load the extensions like every other 
> Artefact?
> Here is an example:
> https://github.com/apache/sling-org-apache-sling-feature-launcher/compare/master...stbischof:extensionInstaller



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to