bdelacretaz commented on a change in pull request #14:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/14#discussion_r616781576
##########
File path: src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java
##########
@@ -203,6 +204,14 @@ public static void setPrincipalAcl(Session session, String
principalName, Collec
}
final PrincipalAccessControlList acl =
getPrincipalAccessControlList(acMgr, principal);
+ if (acl == null) {
Review comment:
IMO it would be good to explain why acl can be null - best might be to
add a comment to the `getPrincipalAccessControlList` to explain that? Or maybe
add a `failIfNull` parameter to that method and move the exception building
there, so that if we used it from elsewhere we'll be aware of that possible
null condition?
The explanation as to why acl can be null was given by Konrad in SLING-10281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
