rombert commented on a change in pull request #15: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/15#discussion_r825520710
########## File path: pom.xml ########## @@ -16,308 +16,309 @@ ~ and limitations under the License. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~--> <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> - <modelVersion>4.0.0</modelVersion> Review comment: Please revert the whitespace-only changes done to the pom file. It makes it hard to review what has actually changed. ########## File path: src/main/java/javax/xml/parsers/FactoryFinder.java ########## @@ -159,7 +159,9 @@ static Object find(String factoryId, String fallbackClassName) } static class ConfigurationError extends Error { - private Exception exception; + //Serial Version UID + private static final long serialVersionUID = 159720375000853069L; Review comment: Why is this needed? ########## File path: src/main/java/org/apache/sling/xss/impl/webconsole/XSSProtectionAPIWebConsolePlugin.java ########## @@ -58,7 +58,9 @@ ) public class XSSProtectionAPIWebConsolePlugin extends HttpServlet { - private static final Logger LOGGER = LoggerFactory.getLogger(XSSProtectionAPIWebConsolePlugin.class); + //Serial Version UID + private static final long serialVersionUID = -8510989967759120654L; Review comment: Why is this needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
