klcodanr commented on a change in pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-xss/pull/15#discussion_r825549430



##########
File path: pom.xml
##########
@@ -16,308 +16,309 @@
   ~ and limitations under the License.
   
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~-->
 <project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
-    <modelVersion>4.0.0</modelVersion>
-    <!-- 
======================================================================= -->
-    <!-- P A R E N T   P R O J E C T                                           
  -->
-    <!-- 
======================================================================= -->
-    <parent>
-        <groupId>org.apache.sling</groupId>
-        <artifactId>sling-bundle-parent</artifactId>
-        <version>41</version>
-        <relativePath />
-    </parent>
+       <modelVersion>4.0.0</modelVersion>
+       <!-- 
======================================================================= -->
+       <!-- P A R E N T   P R O J E C T                                        
     -->
+       <!-- 
======================================================================= -->
+       <parent>
+               <groupId>org.apache.sling</groupId>
+               <artifactId>sling-bundle-parent</artifactId>
+               <version>41</version>
+               <relativePath />
+       </parent>
 
-    <!-- 
======================================================================= -->
-    <!-- P R O J E C T                                                         
  -->
-    <!-- 
======================================================================= -->
-    <artifactId>org.apache.sling.xss</artifactId>
-    <version>2.2.19-SNAPSHOT</version>
+       <!-- 
======================================================================= -->
+       <!-- P R O J E C T                                                      
     -->
+       <!-- 
======================================================================= -->
+       <artifactId>org.apache.sling.xss</artifactId>
+       <version>2.2.19-SNAPSHOT</version>
 
-    <name>Apache Sling XSS Protection API</name>
-    <description>
+       <name>Apache Sling XSS Protection API</name>
+       <description>
         Apache Sling XSS Protection Bundle providing XSS protection based on 
the OWASP AntiSamy and OWASP Java Encoder libraries.
     </description>
 
-    <scm>
-        
<connection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-xss.git</connection>
-        
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-xss.git</developerConnection>
-        
<url>https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-xss.git</url>
-      <tag>HEAD</tag>
-  </scm>
+       <scm>
+               
<connection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-xss.git</connection>
+               
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-xss.git</developerConnection>
+               
<url>https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-xss.git</url>
+               <tag>HEAD</tag>
+       </scm>
 
 
-    <!-- 
======================================================================= -->
-    <!-- B U I L D                                                             
  -->
-    <!-- 
======================================================================= -->
-    <build>
-        <pluginManagement>
-            <plugins>
-                <plugin>
-                    <!-- Extend RAT configuration from parent pom -->
-                    <groupId>org.apache.rat</groupId>
-                    <artifactId>apache-rat-plugin</artifactId>
-                    <configuration>
-                        <excludes combine.children="append">
-                            
<exclude>src/main/resources/ESAPI.properties</exclude>
-                            
<exclude>src/main/resources/validation.properties</exclude>
-                        </excludes>
-                    </configuration>
-                </plugin>
-                <plugin>
-                    <groupId>org.codehaus.mojo</groupId>
-                    <artifactId>animal-sniffer-maven-plugin</artifactId>
-                    <configuration>
-                        <!-- ignore class files referenced from classes copied 
over to target/classes by bnd-maven-plugin -->
-                        <ignores>
-                            <ignore>org.apache.xml.*</ignore>
-                            <ignore>org.apache.commons.*</ignore>
-                            <ignore>javax.servlet.jsp.*</ignore>
-                            <ignore>org.apache.avalon.*</ignore> 
-                            <ignore>org.apache.log.*</ignore> 
-                        </ignores>
-                    </configuration>
-                </plugin>
-            </plugins>
-        </pluginManagement>
+       <!-- 
======================================================================= -->
+       <!-- B U I L D                                                          
     -->
+       <!-- 
======================================================================= -->
+       <build>
+               <pluginManagement>
+                       <plugins>
+                               <plugin>
+                                       <!-- Extend RAT configuration from 
parent pom -->
+                                       <groupId>org.apache.rat</groupId>
+                                       
<artifactId>apache-rat-plugin</artifactId>
+                                       <configuration>
+                                               <excludes 
combine.children="append">
+                                                       
<exclude>src/main/resources/ESAPI.properties</exclude>
+                                                       
<exclude>src/main/resources/validation.properties</exclude>
+                                               </excludes>
+                                       </configuration>
+                               </plugin>
+                               <plugin>
+                                       <groupId>org.codehaus.mojo</groupId>
+                                       
<artifactId>animal-sniffer-maven-plugin</artifactId>
+                                       <configuration>
+                                               <!-- ignore class files 
referenced from classes copied over to target/classes by bnd-maven-plugin -->
+                                               <ignores>
+                                                       
<ignore>org.apache.xml.*</ignore>
+                                                       
<ignore>org.apache.commons.*</ignore>
+                                                       
<ignore>javax.servlet.jsp.*</ignore>
+                                                       
<ignore>org.apache.avalon.*</ignore>
+                                                       
<ignore>org.apache.log.*</ignore>
+                                               </ignores>
+                                       </configuration>
+                               </plugin>
+                       </plugins>
+               </pluginManagement>
 
-        <plugins>
-            <plugin>
-                <groupId>org.apache.sling</groupId>
-                <artifactId>sling-maven-plugin</artifactId>
-            </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-dependency-plugin</artifactId>
-                <executions>
-                    <execution>
-                        <id>unpack</id>
-                        <phase>prepare-package</phase>
-                        <goals>
-                            <goal>unpack</goal>
-                        </goals>
-                        <configuration>
-                            
<outputDirectory>${project.build.directory}/dependencies-classes</outputDirectory>
-                            <artifactItems>
-                                <artifactItem>
-                                    <groupId>org.owasp.antisamy</groupId>
-                                    <artifactId>antisamy</artifactId>
-                                </artifactItem>
-                                <artifactItem>
-                                    <groupId>org.owasp.esapi</groupId>
-                                    <artifactId>esapi</artifactId>
-                                </artifactItem>
-                                <artifactItem>
-                                    <groupId>org.owasp.encoder</groupId>
-                                    <artifactId>encoder</artifactId>
-                                </artifactItem>
-                                <artifactItem>
-                                    <groupId>xalan</groupId>
-                                    <artifactId>xalan</artifactId>
-                                </artifactItem>
-                                <artifactItem>
-                                    <groupId>xml-apis</groupId>
-                                    <artifactId>xml-apis</artifactId>
-                                </artifactItem>
-                            </artifactItems>
-                        </configuration>
-                    </execution>
-                </executions>
-            </plugin>
-            <plugin>
-                <artifactId>maven-resources-plugin</artifactId>
-                <version>3.1.0</version>
-                <executions>
-                    <execution>
-                        <id>copy-resources</id>
-                        <!-- here the phase you need -->
-                        <phase>prepare-package</phase>
-                        <goals>
-                            <goal>copy-resources</goal>
-                        </goals>
-                        <configuration>
-                            
<outputDirectory>${project.build.outputDirectory}</outputDirectory>
-                            <resources>
-                                <resource>
-                                    
<directory>${project.build.directory}/dependencies-classes</directory>
-                                    <excludes>
-                                        <exclude>**/MANIFEST.MF</exclude>
-                                    </excludes>
-                                </resource>
-                            </resources>
-                        </configuration>
-                    </execution>
-                </executions>
-            </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-javadoc-plugin</artifactId>
-                <configuration>
-                    <!-- No javadocs -->
-                    <excludePackageNames>
+               <plugins>
+                       <plugin>
+                               <groupId>org.apache.sling</groupId>
+                               <artifactId>sling-maven-plugin</artifactId>
+                       </plugin>
+                       <plugin>
+                               <groupId>org.apache.maven.plugins</groupId>
+                               <artifactId>maven-dependency-plugin</artifactId>
+                               <executions>
+                                       <execution>
+                                               <id>unpack</id>
+                                               <phase>prepare-package</phase>
+                                               <goals>
+                                                       <goal>unpack</goal>
+                                               </goals>
+                                               <configuration>
+                                                       
<outputDirectory>${project.build.directory}/dependencies-classes</outputDirectory>
+                                                       <artifactItems>
+                                                               <artifactItem>
+                                                                       
<groupId>org.owasp.antisamy</groupId>
+                                                                       
<artifactId>antisamy</artifactId>
+                                                               </artifactItem>
+                                                               <artifactItem>
+                                                                       
<groupId>org.owasp.esapi</groupId>
+                                                                       
<artifactId>esapi</artifactId>
+                                                               </artifactItem>
+                                                               <artifactItem>
+                                                                       
<groupId>org.owasp.encoder</groupId>
+                                                                       
<artifactId>encoder</artifactId>
+                                                               </artifactItem>
+                                                               <artifactItem>
+                                                                       
<groupId>xalan</groupId>
+                                                                       
<artifactId>xalan</artifactId>
+                                                               </artifactItem>
+                                                               <artifactItem>
+                                                                       
<groupId>xml-apis</groupId>
+                                                                       
<artifactId>xml-apis</artifactId>
+                                                               </artifactItem>
+                                                       </artifactItems>
+                                               </configuration>
+                                       </execution>
+                               </executions>
+                       </plugin>
+                       <plugin>
+                               <artifactId>maven-resources-plugin</artifactId>
+                               <version>3.1.0</version>
+                               <executions>
+                                       <execution>
+                                               <id>copy-resources</id>
+                                               <!-- here the phase you need -->
+                                               <phase>prepare-package</phase>
+                                               <goals>
+                                                       
<goal>copy-resources</goal>
+                                               </goals>
+                                               <configuration>
+                                                       
<outputDirectory>${project.build.outputDirectory}</outputDirectory>
+                                                       <resources>
+                                                               <resource>
+                                                                       
<directory>${project.build.directory}/dependencies-classes</directory>
+                                                                       
<excludes>
+                                                                               
<exclude>**/MANIFEST.MF</exclude>
+                                                                       
</excludes>
+                                                               </resource>
+                                                       </resources>
+                                               </configuration>
+                                       </execution>
+                               </executions>
+                       </plugin>
+                       <plugin>
+                               <groupId>org.apache.maven.plugins</groupId>
+                               <artifactId>maven-javadoc-plugin</artifactId>
+                               <configuration>
+                                       <!-- No javadocs -->
+                                       <excludePackageNames>
                         javax.xml.*,
                         *.impl.*
                     </excludePackageNames>
-                </configuration>
-            </plugin>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-surefire-plugin</artifactId>
-                <configuration>
-                    <systemProperties>
-                        
<java.util.logging.config.file>src/test/resources/logging.properties</java.util.logging.config.file>
-                    </systemProperties>
-                </configuration>
-            </plugin>
-            <plugin>
-                <groupId>org.jacoco</groupId>
-                <artifactId>jacoco-maven-plugin</artifactId>
-                <configuration>
-                    <includes>
-                        <include>org/apache/sling/xss/**</include>
-                    </includes>
-                </configuration>
-            </plugin>
-        </plugins>
-    </build>
+                               </configuration>
+                       </plugin>
+                       <plugin>
+                               <groupId>org.apache.maven.plugins</groupId>
+                               <artifactId>maven-surefire-plugin</artifactId>
+                               <configuration>
+                                       <systemProperties>
+                                               
<java.util.logging.config.file>src/test/resources/logging.properties</java.util.logging.config.file>
+                                       </systemProperties>
+                               </configuration>
+                       </plugin>
+                       <plugin>
+                               <groupId>org.jacoco</groupId>
+                               <artifactId>jacoco-maven-plugin</artifactId>
+                               <configuration>
+                                       <includes>
+                                               
<include>org/apache/sling/xss/**</include>
+                                       </includes>
+                               </configuration>
+                       </plugin>
+               </plugins>
+       </build>
 
-    <!-- 
======================================================================= -->
-    <!-- D E P E N D E N C I E S                                               
  -->
-    <!-- 
======================================================================= -->
-    <dependencies>
-        <dependency>
-            <groupId>org.owasp.antisamy</groupId>
-            <artifactId>antisamy</artifactId>
-            <version>1.6.4</version>
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>xml-apis</groupId>
-            <artifactId>xml-apis</artifactId>
-            <version>1.4.01</version>
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>xalan</groupId>
-            <artifactId>xalan</artifactId>
-            <version>2.7.2</version>
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.owasp.esapi</groupId>
-            <artifactId>esapi</artifactId>
-            <version>2.2.3.0</version>
-            <scope>provided</scope>
-            <exclusions>
-                <exclusion>
-                    <groupId>commons-lang</groupId>
-                    <artifactId>commons-lang</artifactId>
-                </exclusion>
-                <exclusion>
-                    <groupId>commons-collections</groupId>
-                    <artifactId>commons-collections</artifactId>
-                </exclusion>
-            </exclusions>
-        </dependency>
+       <!-- 
======================================================================= -->
+       <!-- D E P E N D E N C I E S                                            
     -->
+       <!-- 
======================================================================= -->
+       <dependencies>
+               <dependency>
+                       <groupId>org.owasp.antisamy</groupId>
+                       <artifactId>antisamy</artifactId>
+                       <version>1.6.4</version>
+                       <scope>provided</scope>
+               </dependency>
+               <dependency>
+                       <groupId>xml-apis</groupId>
+                       <artifactId>xml-apis</artifactId>
+                       <version>1.4.01</version>
+                       <scope>provided</scope>
+               </dependency>
+               <dependency>
+                       <groupId>xalan</groupId>
+                       <artifactId>xalan</artifactId>
+                       <version>2.7.2</version>
+                       <scope>provided</scope>
+               </dependency>
+               <dependency>
+                       <groupId>org.owasp.esapi</groupId>
+                       <artifactId>esapi</artifactId>
+                       <version>2.2.3.0</version>
+                       <scope>provided</scope>
+                       <exclusions>
+                               <exclusion>
+                                       <groupId>commons-lang</groupId>
+                                       <artifactId>commons-lang</artifactId>
+                               </exclusion>
+                               <exclusion>
+                                       <groupId>commons-collections</groupId>
+                                       
<artifactId>commons-collections</artifactId>
+                               </exclusion>
+                       </exclusions>
+               </dependency>
 
-        <dependency>
-            <groupId>org.owasp.encoder</groupId>
-            <artifactId>encoder</artifactId>
-            <scope>provided</scope>
-            <version>1.2.2</version>
-        </dependency>
+               <dependency>
+                       <groupId>org.owasp.encoder</groupId>
+                       <artifactId>encoder</artifactId>
+                       <scope>provided</scope>
+                       <version>1.2.2</version>
+               </dependency>
 
-        <dependency>
-            <groupId>javax.servlet</groupId>
-            <artifactId>javax.servlet-api</artifactId>
-            <scope>provided</scope>
-        </dependency>
+               <dependency>
+                       <groupId>javax.servlet</groupId>
+                       <artifactId>javax.servlet-api</artifactId>
+                       <scope>provided</scope>
+               </dependency>
 
-        <dependency>
-            <groupId>org.osgi</groupId>
-            <artifactId>osgi.core</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>org.osgi</groupId>
-            <artifactId>osgi.cmpn</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>org.osgi</groupId>
-            <artifactId>org.osgi.annotation.versioning</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>org.slf4j</groupId>
-            <artifactId>slf4j-api</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.sling</groupId>
-            <artifactId>org.apache.sling.api</artifactId>
-            <version>2.11.0</version>
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-          <groupId>org.apache.sling</groupId>
-          <artifactId>org.apache.sling.serviceusermapper</artifactId>
-          <version>1.2.0</version>
-          <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.jetbrains</groupId>
-            <artifactId>annotations</artifactId>
-            <version>16.0.2</version>
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.geronimo.specs</groupId>
-            <artifactId>geronimo-json_1.0_spec</artifactId>
-            <version>1.0-alpha-1</version>
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.commons</groupId>
-            <artifactId>commons-lang3</artifactId>
-            <version>3.6</version>
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>commons-io</groupId>
-            <artifactId>commons-io</artifactId>
-            <version>2.6</version>
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.sling</groupId>
-            <artifactId>org.apache.sling.commons.metrics</artifactId>
-            <version>1.2.6</version>
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>io.dropwizard.metrics</groupId>
-            <artifactId>metrics-core</artifactId>
-            <version>3.2.3</version>
-            <scope>provided</scope>
-        </dependency>
-        <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>org.mockito</groupId>
-            <artifactId>mockito-all</artifactId>
-            <version>1.10.19</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.powermock</groupId>
-            <artifactId>powermock-api-mockito</artifactId>
-            <version>1.6.5</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.sling</groupId>
-            <artifactId>org.apache.sling.testing.sling-mock.junit4</artifactId>
-            <version>2.3.4</version>
-            <scope>test</scope>
-        </dependency>
-    </dependencies>
+               <dependency>
+                       <groupId>org.osgi</groupId>
+                       <artifactId>osgi.core</artifactId>
+               </dependency>
+               <dependency>
+                       <groupId>org.osgi</groupId>
+                       <artifactId>osgi.cmpn</artifactId>
+               </dependency>
+               <dependency>
+                       <groupId>org.osgi</groupId>
+                       <artifactId>org.osgi.annotation.versioning</artifactId>
+               </dependency>
+               <dependency>
+                       <groupId>org.slf4j</groupId>
+                       <artifactId>slf4j-api</artifactId>
+               </dependency>
+               <dependency>
+                       <groupId>org.apache.sling</groupId>
+                       <artifactId>org.apache.sling.api</artifactId>
+                       <version>2.11.0</version>
+                       <scope>provided</scope>
+               </dependency>
+               <dependency>
+                       <groupId>org.apache.sling</groupId>
+                       
<artifactId>org.apache.sling.serviceusermapper</artifactId>
+                       <version>1.2.0</version>
+                       <scope>provided</scope>
+               </dependency>
+               <dependency>
+                       <groupId>org.jetbrains</groupId>
+                       <artifactId>annotations</artifactId>
+                       <version>16.0.2</version>
+                       <scope>provided</scope>
+               </dependency>
+               <dependency>
+                       <groupId>org.apache.geronimo.specs</groupId>
+                       <artifactId>geronimo-json_1.0_spec</artifactId>
+                       <version>1.0-alpha-1</version>
+                       <scope>provided</scope>
+               </dependency>
+               <dependency>
+                       <groupId>commons-io</groupId>
+                       <artifactId>commons-io</artifactId>
+                       <version>2.6</version>
+                       <scope>provided</scope>
+               </dependency>
+               <!-- 
https://mvnrepository.com/artifact/org.apache.commons/commons-text -->

Review comment:
       Unnecessary comment, can be removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to