[ https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557089#comment-17557089 ]
Eric Norman edited comment on SLING-11398 at 6/21/22 8:12 PM: -------------------------------------------------------------- [~olli] {quote}{quote}Felix HC comes with its own [{{ScriptEnginesTracker}}|https://github.com/apache/felix-dev/blob/master/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/util/ScriptEnginesTracker.java]. So how should enhancing Sling Scripting Core help? {quote}{quote} What are you referring to here? The proposed changes for this issue in PR #18 don't have anything to do with Felix HC or it's private ScriptEnginesTracker. {quote}And the Groovy Runner in Composum Nodes is not using JSR 223 ({{{}javax.script{}}}) at all, {quote} Fair enough, I didn't look at the Composum code too closely. Hopefully you would concede that the "browsing" to /content/slingshot.groovy1 that I also described does flow though the sling scripting and the JSR223 ScriptEngine that we are talking about here. was (Author: enorman): [~olli] {quote}bq. Felix HC comes with its own [{{ScriptEnginesTracker}}|https://github.com/apache/felix-dev/blob/master/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/util/ScriptEnginesTracker.java]. So how should enhancing Sling Scripting Core help? {quote} What are you referring to here? The proposed changes for this issue in PR #18 don't have anything to do with Felix HC or it's private ScriptEnginesTracker. {quote}And the Groovy Runner in Composum Nodes is not using JSR 223 ({{{}javax.script{}}}) at all, {quote} Fair enough, I didn't look at the Composum code too closely. Hopefully you would concede that the "browsing" to /content/slingshot.groovy1 that I also described does flow though the sling scripting and the JCR223 ScriptEngine that we are talking about here. > handle serviceloader ScriptEngineFactory defined in a fragment bundle > --------------------------------------------------------------------- > > Key: SLING-11398 > URL: https://issues.apache.org/jira/browse/SLING-11398 > Project: Sling > Issue Type: Bug > Reporter: Eric Norman > Assignee: Eric Norman > Priority: Major > Fix For: Scripting Core 2.4.10 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Handle loading of ScriptEngineFactory service loader > (/META-INF/services/javax.script.ScriptEngineFactory) files that exist in a > fragment. > For example, consider the groovy ScriptEngine included in the starter that > has these: > Host Bundle - org.codehaus.groovy:groovy:3.0.9 > Fragment - org.codehaus.groovy:groovy-jsr223:3.0.9 > > Expected: > The groovy ScriptEngineFactory declared in the groovy-jsr223 fragment should > be discovered and made available. -- This message was sent by Atlassian Jira (v8.20.7#820007)