[
https://issues.apache.org/jira/browse/SLING-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557109#comment-17557109
]
Eric Norman edited comment on SLING-11398 at 6/21/22 8:37 PM:
--------------------------------------------------------------
[~olli]
{quote}You mentioned above HCs as your primary motivation. How should your PR
or this issue help here? Note: I'm not against the improvement. It will help
with some versions of {{{}groovy-jsr223{}}}.
{quote}
Ok. Well this change is not directly related to the HC fix, but it is intended
to maintain parity to the HC impl. I also made a similar PR for the private
tracker used in the felix HC at FELIX-6542 that is pending and waiting to be
reviewed. I'm not a FELIX committer.
UPDATE: After further review, the SLING-11141 solution now does depend on this
change as that solution now delegates to the sling ScriptEngineManager to get
the ScriptEngine rather than using another tracker. This was to decouple from
felix impl.
was (Author: enorman):
[~olli]
{quote}You mentioned above HCs as your primary motivation. How should your PR
or this issue help here? Note: I'm not against the improvement. It will help
with some versions of {{{}groovy-jsr223{}}}.
{quote}
Ok. Well this change is not directly related to the HC fix, but it is intended
to maintain parity to the HC impl. I also made a similar PR for the private
tracker used in the felix HC at FELIX-6542 that is pending and waiting to be
reviewed. I'm not a FELIX committer.
> handle serviceloader ScriptEngineFactory defined in a fragment bundle
> ---------------------------------------------------------------------
>
> Key: SLING-11398
> URL: https://issues.apache.org/jira/browse/SLING-11398
> Project: Sling
> Issue Type: Bug
> Reporter: Eric Norman
> Assignee: Eric Norman
> Priority: Major
> Fix For: Scripting Core 2.4.10
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Handle loading of ScriptEngineFactory service loader
> (/META-INF/services/javax.script.ScriptEngineFactory) files that exist in a
> fragment.
> For example, consider the groovy ScriptEngine included in the starter that
> has these:
> Host Bundle - org.codehaus.groovy:groovy:3.0.9
> Fragment - org.codehaus.groovy:groovy-jsr223:3.0.9
>
> Expected:
> The groovy ScriptEngineFactory declared in the groovy-jsr223 fragment should
> be discovered and made available.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
