+1, I don’t think that the changes for https://issues.apache.org/jira/browse/SLING-11463 <https://issues.apache.org/jira/browse/SLING-11463> were actually necessary as a DS component is reactivated if a configuration is changed and doesn’t have a modified method. Compare with https://github.com/apache/sling-org-apache-sling-installer-hc/commit/82096759de3e5d0b791a1f45c8fe2e759b5ae391#r78840724 <https://github.com/apache/sling-org-apache-sling-installer-hc/commit/82096759de3e5d0b791a1f45c8fe2e759b5ae391#r78840724>.
IMHO adding a modified just allows to reconfigure while the component is running which is not necessary here. Konrad > On 19. Jul 2022, at 00:03, Oliver Lietz <[email protected]> wrote: > > Hi, > > We solved 4 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12345553 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2656 > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2656 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > O. > > > >
