On Wednesday, 20 July 2022 10:41:04 CEST Oliver Lietz wrote: > On Tuesday, 19 July 2022 08:27:23 CEST Konrad Windszus wrote: > > +1, > > > > I don’t think that the changes for > > https://issues.apache.org/jira/browse/SLING-11463 > > <https://issues.apache.org/jira/browse/SLING-11463> were actually > > necessary > > as a DS component is reactivated if a configuration is changed and doesn’t > > have a modified method. Compare with > > https://github.com/apache/sling-org-apache-sling-installer-hc/commit/82096 > > 7 > > 59de3e5d0b791a1f45c8fe2e759b5ae391#r78840724 > > <https://github.com/apache/sling-org-apache-sling-installer-hc/commit/8209 > > 6 > > 759de3e5d0b791a1f45c8fe2e759b5ae391#r78840724>. > > > > IMHO adding a modified just allows to reconfigure while the component is > > running which is not necessary here. Konrad > > That is not true for Felix at least. The component will not be reactivated > but recreated. Felix will create a complete new instance if modified is > missing which causes unnecessary fluctuation.
I've added some more unit tests and an integration test (which increased coverage from ~20% to ~90%). If you have doubt I can quickly add an IT to proof my statement from above. O. [...]
