[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results

[GitBox]

reschke commented on code in PR #81:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961654779


##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -1303,7 +1319,13 @@ private Map<String, List<String>> 
loadVanityPaths(ResourceResolver resolver) {
                 countInScope += 1;
                 final boolean addToCache = isAllVanityPathEntriesCached()
                         || vanityCounter.longValue() < 
this.factory.getMaxCachedVanityPathEntries();
-                loadVanityPath(resource, resolveMapsMap, targetPaths, 
addToCache);
+                String firstVanityPath = loadVanityPath(resource, 
resolveMapsMap, targetPaths, addToCache);
+                if (supportsSort && firstVanityPath != null) {
+                    if (previousVanityPath != null && 
firstVanityPath.compareTo(previousVanityPath) < 0) {
+                        log.error("Sorting by first(vanityPath) does not 
appear to work; got " + firstVanityPath + " after " + previousVanityPath);

Review Comment:
   We're on the same server, no? Unless I'm missing something, sorting should 
be strictly by Unicode code points, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org