[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results

[GitBox]

reschke commented on code in PR #81:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961658414


##########
src/test/java/org/apache/sling/resourceresolver/impl/mapping/InMemoryResourceProvider.java:
##########
@@ -103,7 +103,7 @@ public Iterator<Resource> findResources(@NotNull 
ResolveContext<Void> ctx, Strin
                         .iterator();
                 }
 
-                if ( "JCR-SQL2".equals(language) && "SELECT 
[sling:vanityPath], [sling:redirect], [sling:redirectStatus] FROM [nt:base] 
WHERE NOT isdescendantnode('/jcr:system') AND [sling:vanityPath] IS NOT 
NULL".equals(query) ) {
+                if ( "JCR-SQL2".equals(language) && "SELECT 
[sling:vanityPath], [sling:redirect], [sling:redirectStatus] FROM [nt:base] 
WHERE NOT isdescendantnode('/jcr:system') AND [sling:vanityPath] IS NOT NULL 
ORDER BY FIRST([sling:vanityPath]), [jcr:path]".equals(query) ) {

Review Comment:
   Yes, we'll get to that next.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org