[
https://issues.apache.org/jira/browse/SLING-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695891#comment-17695891
]
Eric Norman commented on SLING-11728:
-------------------------------------
[~olli] Not sure if it is related to timing. My quick look at it indicates
that the SlingServletResolver's implementation of ErrorHandler was never bound
as the DefaultErrorHandler's delegate during the test. Then the error handling
servlets were never considered and it falls back to the default error handling.
I was able to get the tests to pass locally by applying this patch which I
guess is what Carsten was alluding to:
{code:java}
diff --git a/pom.xml b/pom.xml
index cbcb787..497a608 100644
--- a/pom.xml
+++ b/pom.xml
@@ -239,7 +239,7 @@
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.engine</artifactId>
- <version>2.12.3-SNAPSHOT</version>
+ <version>2.14.1-SNAPSHOT</version>
<scope>provided</scope>
</dependency>
<dependency>
diff --git
a/src/test/java/org/apache/sling/servlets/resolver/it/ServletResolverTestSupport.java
b/src/test/java/org/apache/sling/servlets/resolver/it/ServletResolverTestSupport.java
index 1789aa9..ef6c4f7 100644
---
a/src/test/java/org/apache/sling/servlets/resolver/it/ServletResolverTestSupport.java
+++
b/src/test/java/org/apache/sling/servlets/resolver/it/ServletResolverTestSupport.java
@@ -103,6 +103,9 @@
versionResolver.setVersionFromProject(SLING_GROUP_ID,
"org.apache.sling.commons.johnzon");
versionResolver.setVersionFromProject(SLING_GROUP_ID,
"org.apache.sling.engine");
versionResolver.setVersion(SLING_GROUP_ID,
"org.apache.sling.auth.core", "1.6.0");
+
+ versionResolver.setVersion("commons-fileupload", "commons-fileupload",
"1.5");
+
return options(
composite(
when(debugOption != null).useOptions(debugOption), {code}
> Remove bi-directional dependencies between Engine and Servlets Resolver
> -----------------------------------------------------------------------
>
> Key: SLING-11728
> URL: https://issues.apache.org/jira/browse/SLING-11728
> Project: Sling
> Issue Type: Improvement
> Components: API, Engine, Servlets
> Affects Versions: Engine 2.12.0
> Reporter: Oliver Lietz
> Assignee: Oliver Lietz
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> *Situation*
> * bundle {{org.apache.sling.engine}} requires a {{ServletResolver}} which is
> provided by bundle {{org.apache.sling.servlets.resolver}}
> * bundle {{org.apache.sling.servlets.resolver}} depends on
> {{org.apache.sling.engine.servlets}} API
> The bi-directional dependencies between Engine and Servlets Resolver prevent
> the creation of meaningful and light deployment units (testing, features).
> *Options*
> # Merge {{org.apache.sling.engine}} and
> {{org.apache.sling.servlets.resolver}} into a single entity (bundle)
> # Move {{org.apache.sling.engine.servlets.ErrorHandler}} into Sling API
> (package {{org.apache.sling.api.servlets}}) and adjust usage in Servlets
> Resolver
> # Keep as is – leading to bigger, less manageable deployment units
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
