[
https://issues.apache.org/jira/browse/SLING-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696034#comment-17696034
]
Carsten Ziegeler commented on SLING-11728:
------------------------------------------
Thanks [~olli] . I did a quick test with the servlets resolver bundle and
changed the error handler implementation back to use the old interface from
engine (see below). Then the tests fail. I assume this is due to the engine
bundle looking for a service registration with the new interface, whereas in
this case it will be reqistered with the old interface. We probably need to
handle this case in the engine.
{code:java}
diff --git
a/src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java
b/src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java
index 81a99c9..05a8905 100644
—
a/src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java
+++
b/src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java
@@ -49,7 +49,7 @@ import org.apache.sling.api.resource.ResourceResolver;
import org.apache.sling.api.resource.ResourceResolverFactory;
import org.apache.sling.api.resource.ResourceUtil;
import org.apache.sling.api.resource.SyntheticResource;
-import org.apache.sling.api.servlets.ErrorHandler;
+import org.apache.sling.engine.servlets.ErrorHandler;
import org.apache.sling.api.servlets.OptingServlet;
import org.apache.sling.api.servlets.ServletResolver;
import org.apache.sling.api.servlets.ServletResolverConstants;{code}
> Remove bi-directional dependencies between Engine and Servlets Resolver
> -----------------------------------------------------------------------
>
> Key: SLING-11728
> URL: https://issues.apache.org/jira/browse/SLING-11728
> Project: Sling
> Issue Type: Improvement
> Components: API, Engine, Servlets
> Affects Versions: Engine 2.12.0
> Reporter: Oliver Lietz
> Assignee: Oliver Lietz
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> *Situation*
> * bundle {{org.apache.sling.engine}} requires a {{ServletResolver}} which is
> provided by bundle {{org.apache.sling.servlets.resolver}}
> * bundle {{org.apache.sling.servlets.resolver}} depends on
> {{org.apache.sling.engine.servlets}} API
> The bi-directional dependencies between Engine and Servlets Resolver prevent
> the creation of meaningful and light deployment units (testing, features).
> *Options*
> # Merge {{org.apache.sling.engine}} and
> {{org.apache.sling.servlets.resolver}} into a single entity (bundle)
> # Move {{org.apache.sling.engine.servlets.ErrorHandler}} into Sling API
> (package {{org.apache.sling.api.servlets}}) and adjust usage in Servlets
> Resolver
> # Keep as is – leading to bigger, less manageable deployment units
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
