jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387260516
##########
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##########
@@ -152,7 +154,9 @@ private static void setAcl(Session session, List<String>
principals, String jcrP
boolean changed = false;
for (String name : principals) {
- Principal principal = AccessControlUtils.getPrincipal(session,
name);
+ Principal principal = options.contains("ignoreMissingPrincipal")
+ ? () -> name
Review Comment:
Sounds sensible. Thanks for catching this change in logic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
