jsedding commented on code in PR #45:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/45#discussion_r1387262475
##########
src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java:
##########
@@ -152,7 +154,9 @@ private static void setAcl(Session session, List<String>
principals, String jcrP
boolean changed = false;
for (String name : principals) {
- Principal principal = AccessControlUtils.getPrincipal(session,
name);
+ Principal principal = options.contains("ignoreMissingPrincipal")
Review Comment:
+1 to both points.
Regarding documentation, it's probably best to add a test-case example in
the repoinit parser module. AFAIK the test files are included in the
documentation. I suppose that's the downside of having `ACLOptions` accept all
strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
