[
https://issues.apache.org/jira/browse/SLING-12885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013582#comment-18013582
]
Carsten Ziegeler commented on SLING-12885:
------------------------------------------
I initially went down the same route, but couldnt find a good way to make this
work.
I think the proposed solution is not going to work. it will fail as soon as you
have old and new code in parallel which is a scenario we need to support.
We could remove the deprecated tag from AuthenticationHandler class and then
add it to every member except the enum. This is not super nice, but would solve
the issue that the enum appears as deprecated in code.
> AuthenticationHandler.FAILURE_REASON_CODES is deprecated with no
> non-deprecated replacement
> -------------------------------------------------------------------------------------------
>
> Key: SLING-12885
> URL: https://issues.apache.org/jira/browse/SLING-12885
> Project: Sling
> Issue Type: Improvement
> Reporter: Eric Norman
> Assignee: Eric Norman
> Priority: Major
> Fix For: Auth Core 2.0.2
>
>
> The AuthenticationHandler.FAILURE_REASON_CODES enum is marked as deprecated
> but the enum name is still used as the value of the "j_reason_code" request
> parameter for forms auth.
> Any custom login page can not translate the "j_reason_code" string back to an
> enum for ease of use without ignoring or suppressing warnings about usage of
> the deprecated enum type.
> Suggest creating a mirror enum in the JakartaAuthenticationHandler class so
> the info is not deprecated
> A new configuration field can be used to continue using the deprecated enum
> for backward compatiblity if needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
