[
https://issues.apache.org/jira/browse/SLING-12885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013587#comment-18013587
]
Eric Norman commented on SLING-12885:
-------------------------------------
[~cziegeler] I see, so you know of other auth implementations that require the
FAILURE_REASON_CODE request attribute to be that specific enum type? When I
was looking around I only saw the auth.form usage which seems to be treating
that attribute value as a generic Enum, and not specifically the
AuthenticationHandler one. But if there are others auth handlers that are
problematic then I will defer to your conclusions.
I suppose I could also solve the deprecation warnings with a local mirror copy
of that enum and leave auth.core as it was since I was always converting it
from the string request param value to the Enum anyways.
> AuthenticationHandler.FAILURE_REASON_CODES is deprecated with no
> non-deprecated replacement
> -------------------------------------------------------------------------------------------
>
> Key: SLING-12885
> URL: https://issues.apache.org/jira/browse/SLING-12885
> Project: Sling
> Issue Type: Improvement
> Reporter: Eric Norman
> Assignee: Eric Norman
> Priority: Major
> Fix For: Auth Core 2.0.2
>
>
> The AuthenticationHandler.FAILURE_REASON_CODES enum is marked as deprecated
> but the enum name is still used as the value of the "j_reason_code" request
> parameter for forms auth.
> Any custom login page can not translate the "j_reason_code" string back to an
> enum for ease of use without ignoring or suppressing warnings about usage of
> the deprecated enum type.
> Suggest creating a mirror enum in the JakartaAuthenticationHandler class so
> the info is not deprecated
> A new configuration field can be used to continue using the deprecated enum
> for backward compatiblity if needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
