bkkothari2255 commented on PR #69:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/69#issuecomment-3740101926
> please note that the sling parent already contains a dependency management
section with
>
> ```
> <dependency>
> <groupId>org.junit</groupId>
> <artifactId>junit-bom</artifactId>
> <version>${junit5.version}</version>
> <type>pom</type>
> <scope>import</scope>
> </dependency>
> ```
>
> thus it's not required to include the actual version for junit 5 artifacts
here.
>
> and it should be enough to include only the
`org.junit.jupiter:junit-jupiter` artifact instead of
`org.junit.jupiter:junit-jupiter-api` `org.junit.jupiter:junit-jupiter-api` and
`org.junit.jupiter:junit-jupiter-engine`
Ah, I missed that the parent POM already manages the JUnit BOM. Thanks for
pointing that out!
@stefanseifert I’ve updated the `pom.xml` to:
1. Removed the explicit <version> tags.
2. Consolidate `junit-jupiter-api` and `engine` into the single
`junit-jupiter` artifact.
Pushing the fix now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
