bkkothari2255 commented on PR #69: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/69#issuecomment-3741046322
> This looks good to me and seems to work. The only nitpick I have is that the assertDoesNotThrow usage is the only Assertion method that is using a static import to shorten the code. So for consistency, maybe change those to "Assertions.assertDoesNotThrow" and remove the static import or use a static import for all of used assertion methods and shorten everywhere? I agree, I have pushed the change. Thanks for pointing that out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
