bdelacretaz commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/7#issuecomment-5291166240
The changes seem to make sense but it took me a while (5 years after I last worked on this module ;-) to understand what's going on. I think it would be much better to demonstrate and test the changes with a new partial example that demonstrate this, under src/test/resources/partials. Ideally we'd have an example there that parses only if the changes of this PR are applied, demonstrating what failed before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
