schulm commented on code in PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/7#discussion_r3784705979
##########
src/test/java/org/apache/sling/graphql/schema/aggregator/impl/PartialReaderTest.java:
##########
@@ -146,13 +146,39 @@ public void invalidSectionName() throws Exception {
PartialReader.SyntaxException.class,
() -> new PartialReader(
PartialInfo.EMPTY,
-
getStringReaderSupplier(String.format("PARTIAL:test\n%s:something\n",
invalidName))));
+
getStringReaderSupplier(String.format("%s:something\nPARTIAL:test\n",
invalidName))));
final String expected = "Invalid section name 'REQUIRE'";
assertTrue(
String.format("Expected %s in %s", expected, e.getMessage()),
e.getMessage().contains(expected));
}
+ @Test
+ public void unknownSectionLikeLineInsideSectionIsIgnored() throws
Exception {
Review Comment:
Suggstion - Add the realistic Ibiza partial under
src/test/resources/partials and parse it in a regression
maintainer. Current inline tests are behaviorally sufficient, but don’t
document the real-world format. [test-coverage-analyst v0.2.0]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
