Hi

Basically sounds good.

Am 07.08.2013 um 09:55 schrieb Bertrand Delacretaz:

> Here's my revised proposal based on this thread's discussions:
> 
> 1. Add a "context" service property to our existing
> BindingValuesProvider (BVP) implementations, value="request". The
> context property can have multiple values.

This would be a service reference filter of

   (|(context=request)(!(context=*)))

(I think)

> 
> 2. Modify the scripting setup in DefaultSlingScript so that any BVP
> which has a "context" service property which doesn't include a
> "request" value is ignored. Maybe warn if a BVP with no "context"
> property is found, as we'd like people to add this property from now
> on.

When using the service reference filter (or target on the @Reference 
annotation) we don't really care. Not sure, whether we should really warn ...

In fact I would say, that BVPs without the property should just be used 
anywhere.

The problem is that BVP is a @ConsumerType service interface in the Sling API. 
We must take extreme care to change it or its semantics.

> 
> 3. Provide a service to collect relevant BVPs when setting up
> scripting, based on a set of context values.

Since the selection is so easy with a service selection filter or target 
attribute on a @Reference annotation, such a service would be overkill ;-)

Regards
Felix

> 
> -Bertrand

Reply via email to