No, I mean not having these at all :) and just have them as service properties. Filtering services based on the tags can be done using the filter expression based on service properties and registering the checks as mbeans works this way as well. Do we have other use cases ?
Carsten 2013/8/14 Bertrand Delacretaz <[email protected]> > Hi Carsten, > > On Tue, Aug 13, 2013 at 8:27 PM, Carsten Ziegeler <[email protected]> > wrote: > > ...we briefly discussed this during the refactoring and I think we > agreed :) > > that the current properties (for which constants are defined) should > > actually be service registration properties.... > > Not sure what you mean...adding getters for these properties? > > Having HealthCheck.getName(), HealthCheck.getTags() etc. would indeed > allow for removing the getInfo() method which is good. > > If that's what you mean I can make the changes later today, and get > rid of the Constants class as well. > > -Bertrand > -- Carsten Ziegeler [email protected]
