+1 A small note, not blocking the release: building with the rat profile fails due to README.md not being excluded from the license check ; filed SLING-3745 [1] .
Robert [1]: https://issues.apache.org/jira/browse/SLING-3745 On Tue, Jul 8, 2014 at 8:30 AM, Chetan Mehrotra <chetan.mehro...@gmail.com> wrote: > Hi Oliver, > > On Tue, Jul 8, 2014 at 1:10 AM, Oliver Lietz <apa...@oliverlietz.de> wrote: >> sh check_staged_release.sh 1076 /tmp/sling-staging > > +1 for the release. > All checks ok > > One minor note - Currently quite a few classes are part of public > package 'org.apache.sling.scripting.thymeleaf'. May be all are not > required in Export-Package like SlingWebContext, > ThymeleafScriptEngine, ThymeleafScriptEngineFactory. > > Chetan Mehrotra -- Sent from my (old) computer
