On Tuesday 08 July 2014 07:30:26 Chetan Mehrotra wrote: > Hi Oliver, Hi Chetan,
> On Tue, Jul 8, 2014 at 1:10 AM, Oliver Lietz <apa...@oliverlietz.de> wrote: > > sh check_staged_release.sh 1076 /tmp/sling-staging > > +1 for the release. > All checks ok > > One minor note - Currently quite a few classes are part of public > package 'org.apache.sling.scripting.thymeleaf'. May be all are not > required in Export-Package like SlingWebContext, > ThymeleafScriptEngine, ThymeleafScriptEngineFactory. thanks for having a closer look and sharing your opinion. They are indeed not required and I will move them to impl before the next release. I hadn't a strong opinion on that as some of our other scripting bundles handle it similar and some not. Regards, O. > Chetan Mehrotra